search

4JX / L5P-Keyboard-RGB

Cross platform software to control the RGB/lighting of the 4 zone keyboard included in the 2020, 2021, 2022 and 2023 lineup of the Lenovo Legion laptops. Works on Windows and Linux.
GNU General Public License v3.0
308 stars 39 forks source link

[Question] Do you accept pull requests for new effects? #90

Closed ccelik97 closed 1 year ago

ccelik97 commented 1 year ago

Hi again and thanks for implementing an user-adjustable FPS limit for the AmbientLight effect. With that provided I managed to make an altered version of it that matches my preferences more closely.

Do you accept pull requests for new effect profiles here? And if so how should be the code of the new effects formatted?

4JX commented 1 year ago

Yeah, contributions are always welcome!

Formatting should be done with cargo fmt (your editor probably already uses that under the hood for rust projects), the rustfmt.toml config file should take care of making it have the appropriate formatting.

I don't see a fork within your repos, mind uploading one/describing what you changed?

ccelik97 commented 1 year ago

your editor probably already uses that under the hood for rust projects

Yeah, I'm using TabNine in VS Code and I also have Prettier (didn't change any of it's settings).

Btw I had a little issue figuring out exactly what I need to build the project on Windows. Apparently GitHub Actions' Windows environment has LLVM & Clang tools all ready to go but on my machine I ended up discovering this AIO toolchain. Linux side was fine though as I had clang installed along with it's dependencies.

I don't see a fork within your repos

That's because I did my changes locally and I was waiting for you to say that contributions are welcome. :D Let me fork it then.

ccelik97 commented 1 year ago

Done. The pull request is awaiting your approval over here: https://github.com/4JX/L5P-Keyboard-RGB/pull/92