4PointSolutions / FluentFormsAPI

Fluent API for Adobe AEM Forms
Apache License 2.0
6 stars 8 forks source link

Some Unit Tests are under incorrect package #14

Closed rmcdouga closed 3 years ago

rmcdouga commented 4 years ago

Unit tests are typically in the same package as the class they are testing in order to give them access to package private methods (for whitebox tests).

The tests for the forms, docassurance, and assembler services are under the api package rather than the impl package, This is incorrect as we are really testing the implementations, not the interfaces. They should be moved to a package under com._4point.aem.fluentforms.impl.

There's fair amount of development going on at the time of this issue creation so it would be inconvenient to make this change now. This issue is being created as a reminder to do this once the development hits a quiet period.