search

4PointSolutions / FluentFormsAPI

Fluent API for Adobe AEM Forms
Apache License 2.0
6 stars 8 forks source link

Rest server changes #17

Closed chikhaleprajaktaPFG closed 4 years ago

chikhaleprajaktaPFG commented 4 years ago

7

chikhaleprajaktaPFG commented 4 years ago

Hi Rob,

I have added a test case but currently it is failing while getting assemblerResult Object for other properties. It is working fine for map of documents but I am getting null pointer when I tries to retrieve other properties like failedOnBlocks , logLevel etc..I am working on it...Please, let me know if you I am missing something in code which can be cause of the issue mentioned above.. Also, I have good news to share..My changes are working ...I mean I did my testing on last last week monday and worked as expected...So I guess I am just waiting to have all the changes to be committed in master so I can proceed with pilot testing.

Regards, Prajakta

chikhaleprajaktaPFG commented 4 years ago

Hi Rob,

My Apologies , I may have created little misunderstanding with my statement "waiting for the changes to be committed in master". What I meant to say here is once we close the all the(5) issues which you have created for assembler service then we can be ready to have the changes in master.I am using #4 for the testing purpose as it has working code..When ever you suggest new changes I tries to implement that in #4 branch first and then the testing with plugin to verify the result. I, In fact think the same that #4 is no where near to merge the changes in master, I liked our current approach of doing the changes in piece by piece and testing with unit test cases that actually, improves the code quality and it helps to maintain the coding standard also.

Also, As per your suggestion for AssemblerTest null pointer exception I have done the changes but at jobLog level ..I am still getting the null pointer issue even thought I have added null check there...Job log level is returning a document here so it passed my null check and when tries to call any get method in gives me nullpointer. I am bit struggling there so I have commented that part as of now. It will be great help, If I get know what I am missing when tries to read jobLog level value.

Regards, Prajakta