search

4PointSolutions / FluentFormsAPI

Fluent API for Adobe AEM Forms
Apache License 2.0
6 stars 8 forks source link

Committing client code changes : RestServicesDocAssemblerServiceAdapt… #18

Closed chikhaleprajaktaPFG closed 4 years ago

chikhaleprajaktaPFG commented 4 years ago

Hi Rob,

I am raising this pull request as I am facing some challenges while running integration test cases on test server. As we have given date to have the changes available on Pilot by Monday. So I thought It would be good that all the changes fleunt api , rest server and rest client should be in the master. Once those are pilot ready ,I will focus on integration test cases also. Please, let me know about your concerns and questions to this approach.

Regards, Prajakta

rmcdouga commented 4 years ago

I can't in good conscience check the code in without unit tests, so I created some unit tests for the client code. The tests are not complete. Currently error conditions are not being tested, but this will have to do as I don't have time to do more tonight.

If there are missing tests, then that means that the code has not been thoroughly tested. If the code has not been thoroughly tested, then it is not really "done".

Going to pilot with code that has not been thoroughly tested and is not really done seems like a bad idea to me. This is essentially pretending that the code is in a better state than it really is. It's hoping that the code has no defects rather than knowing that the code has no defects.

Having said that, if you guys want to roll the dice, I'm not going to stand in your way. With the additional unit tests, I at least know that the code is not terribly broken so I will go ahead and commit it.