search

4PointSolutions / FluentFormsAPI

Fluent API for Adobe AEM Forms
Apache License 2.0
6 stars 8 forks source link

Export method for PDF to HTML conversion #5

Closed RainaRitikaPFG closed 4 years ago

RainaRitikaPFG commented 4 years ago

Export method

RainaRitikaPFG commented 4 years ago

Hi Rob,

I have committed my unit tests. Is there any other changes you are expecting from my side or we are good with merging.

Thanks, Ritika.

rmcdouga commented 4 years ago

Hi Ritika,

Please see my latest comments (in one of the threads above) on how to get the integration tests running. I hope that helps. Getting the integration tests working is important because that's the first layer that shows that everything is working when connected to a real AEM instance.

Regards, Rob

RainaRitikaPFG commented 4 years ago

Hi Rob, I have committed integration tests. I am able to test the content inside the xml and made sure that we are getting xml content type. Though I am still facing issue with printing the dom document which I think is not required in the integration test point of view. We have a plugin which creates pdf to html where I am able to retrieve the xml dom document, so we are good from the structure side also. Let me know if we require any change in the code.

Thanks, Ritika.

rmcdouga commented 4 years ago

Changes merged into the main branch. Thanks for the contribution Ritika!