4Q-s-r-o / ota_update

Flutter plugin implementing OTA update for both iOS and Android
MIT License
182 stars 62 forks source link

Add namespace field to build.gradle #110

Closed ooguz closed 10 months ago

ooguz commented 10 months ago

Summary

On Flutter 3.16, kiosk_mode package fails to build with the error message below:

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':ota_update'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

That's why I added namespace field to build.gradle file.

MartinHlavna commented 10 months ago

Hello, looks like #109 already solves this in a more complex way.

Thanks for PR, though I am closing this PR in favor of #109 since your change is already included in that PR.