search

4Q-s-r-o / signature

Flutter plugin that creates a canvas for writing down a signature
MIT License
252 stars 83 forks source link

Signature flutter3 #69

Closed yurtemre7 closed 1 year ago

yurtemre7 commented 2 years ago

Hey,

I have made major improvements to the example project by updating everything to flutter 3 and making the project better then before by splitting widgets and better ui for simple widget tests.

I have also made a discovery of a bad hard-code in the signature.dart file of the package. The toPngBytes method would always make the image 500x400 which is not wanted. Now user can specify a desired height and width, which is still validated in toImage to not be less then the original height and width.

If something is unclear, feel free to contact me via Telegram or E-Mail. We can go through all the changes and I hope I can make a good contribution to this package because I personally use it for my work.

MartinHlavna commented 1 year ago

Other changes looks good to me.

MartinHlavna commented 1 year ago

I have merged branches manually. I have cherry picked everything but the kotlin migration and also left old package namespace (We are maintaining multiple packages and have all of them on com.example would cause them to overwrite examples which is not something we want).

I am open about discussion on kotlin but since there is no native code I see little reason for that change. Thanks for the test, it is great addition and will contribute to providing more stable builds.

Keep up the good work. Thanks!

yurtemre7 commented 1 year ago

Alright! Thank you!