search

4Science / DSpace

This repository contains the 4Science optimized DSpace & DSpace-CRIS distribution.
https://wiki.lyrasis.org/display/DSPACECRIS/
BSD 3-Clause "New" or "Revised" License
41 stars 61 forks source link

openaire-lit-v4_dspace5 #162

Open gabrielaatmac opened 4 years ago

gabrielaatmac commented 4 years ago

Hello,

I am using the openaire-lit-v4_dspace5 to harvest data from multiple repositories and then I expose that data to OpenAIRE. While implementing the project I came across these issues with the how dc.relation field is used in openaire-lit-v4_dspace5.

openaire-lit-v4_dspace5 uses dc.relation to store the "Award Title" information, but the dc.relation can be used (as per the field's description) for "Catch-all for references to other related items.". If the dc.relation field contains information that is not the award title, all that info is mapped to oaire:awardTitle.

Also, it is not clear how to handle multiple funders. The matching for the block below (for the record https://canadaresearch.mcmaster.ca/handle/123456789/6669?mode=full) seems to be based on the order of entering the information. Please note:

image

Thank you, Gabriela

abollini commented 3 years ago

Hi Gabriela, thanks for looking to our implementation and provide feedback. I agree with your comments, unfortunately we cannot avoid the need for institutions that doesn't run a vanilla dspace installation to make adaption to use this code in their repository. The mapping has been designed to anticipate what the community has decide to be the default for the next DSpace 7 version https://github.com/DSpace/DSpace/blob/main/dspace/config/submission-forms.xml#L884-L897 This mapping is still open as DSpace 7 is not yet released but so far, the unqualified dc.relation will be used to store the information about the awards title. Please note that in a vanilla dspace such metadata is not currently used.

To switch from dc.relation to something else you need to customize your input-forms.xml and change the oaire crosswalk accordly, this is the affected line https://github.com/4Science/DSpace/blob/openaire-lit-v4_dspace5/dspace/config/crosswalks/oai/metadataFormats/oai_openaire.xsl#L228 <xsl:variable name="awardtitle" select="doc:metadata/doc:element[@name='dc']/doc:element[@name='relation']/doc:element/doc:field[@name='value']"/> pay attention to add an additional /doc:element[@name='<YOUR-QUALIFIER>'] in the xpath before the last doc:element if you use a qualified metadata

Multiple funding reference are not officially supported, this because DSpace lacks of support for nested metadata (that is instead available in DSpace-CRIS) or external entities (that is going to be introduced in DSpace7 and present in DSpace-CRIS). But you got right the trick that can be used to manage them. You need to be sure to put all the information for all the funding and they will be "pair" according to the order.

A fix is coming for the mess Award URI and we will switch from Awards Title to Funding Name to decide if the funding block must be included or not (as the Funding Name is Mandatory according to the guidelines).

lap82 commented 3 years ago

Hello @gabrielaatmac ,

thanks for sharing the issue. As reported by @abollini the enhancement has been shared at https://github.com/4Science/DSpace/commit/b2d2753711277fd4ad1a46bf9f8977198ab5fd5f and https://github.com/4Science/DSpace/commit/62db2d104c117618595b5ad41084ede961ad79e6

Hope this helps you.

gabrielaatmac commented 3 years ago

Thank you for the enhancement.

I opened a bug against DSpace 7 at https://jira.lyrasis.org/browse/DS-4550 regarding the use of dc.relation.

Best wishes, Gabriela

gabrielaatmac commented 3 years ago

Thank you very much for your assistance so far.

@abollini I already received the first assessment fro my DSpace 7 bug report.

Apparently the latest "oaire" schema in DSpace 7 has an "oaire.awardTitle" field: https://github.com/DSpace/DSpace/blob/main/dspace/config/registries/openaire4-types.xml#L42-L46 For more details, please see the comments at https://jira.lyrasis.org/browse/DS-4550

Best wishes, Gabriela

gabrielaatmac commented 3 years ago

Hello Andrea and Luigi,

Do you have an update on this?

Thank you, Gabriela

abollini commented 3 years ago

I have read the ticket and discussion about the version 7 and unfortunately I think it's really confusing ;) Having a different mapping for a metadata depending on the fact that entities are used or not don't seem to me a good solution, anyway this is something that should be addressed in version 7. Probably it would be easier for user of version 5 and 6 that want to be compliant with the v4 guidelines to introduce a new dedicated field for the project and we can eventually use oaire.awardTitle for that. @gabrielaatmac do you agree? should we update the patch to reflect this change?

@sulfurchesh @pilasou @toniprieto as you have tested the patch in the past are you fine with the proposed change here?

sulfurchesh commented 3 years ago

We're using the v5 patch, and that seems like a reasonable change to me.

toniprieto commented 3 years ago

It also seems like a reasonable change to me.

gabrielaatmac commented 3 years ago

Thank you very much @abollini and apologies for the late reply, I was on vacation for a couple of weeks. I agree with the proposed changes. Please go ahead and update the patch to reflect this change.

Best wishes, Gabriela