In the latest DSpace CRIS release, 2023.01.00, the class org.dspace.validation.DetectPotentialDuplicateValidator was added.
A RuntimeException is raised (in the private method findDuplicates) if the database server or Solr server is not accessible. In consequence, this exception is not caught and results in HTTP 500 responses when the UI tries to open "edit forms" of items in collections that are associated with a detect-duplicate step in item-submission.xml.
It should be considered to catch exceptions of type SQLException or SearchServiceException locally in DetectPotentialDuplicateValidator and change this code block (line 90)
} catch (SQLException | SearchServiceException e) {
throw new RuntimeException(e); // FIXME remove this line
}
Instead a proper log message with log level ERROR or WARN should be generated.
In the latest DSpace CRIS release, 2023.01.00, the class
org.dspace.validation.DetectPotentialDuplicateValidator
was added.A
RuntimeException
is raised (in the private methodfindDuplicates
) if the database server or Solr server is not accessible. In consequence, this exception is not caught and results in HTTP 500 responses when the UI tries to open "edit forms" of items in collections that are associated with adetect-duplicate
step initem-submission.xml
.It should be considered to catch exceptions of type
SQLException
orSearchServiceException
locally inDetectPotentialDuplicateValidator
and change this code block (line 90)Instead a proper log message with log level ERROR or WARN should be generated.