search

4Science / DSpace

This repository contains the 4Science optimized DSpace & DSpace-CRIS distribution.
https://wiki.lyrasis.org/display/DSPACECRIS/
BSD 3-Clause "New" or "Revised" License
42 stars 61 forks source link

explore pages contain form elements with non-unique ID values #369

Closed saschaszott closed 1 year ago

saschaszott commented 1 year ago

Some pages contain DOM form elements ( select and input) with non-unique IDs. The warnings above were taken from the browser console.

/explore/researcherprofiles

Found 3 elements with non-unique id #filter: (More info: https://goo.gl/9p2vKq) <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​ <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​ <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​

Found 2 elements with non-unique id #operation: (More info: https://goo.gl/9p2vKq) <select name=​"operation" id=​"operation" formcontrolname=​"operation" class=​"form-control ng-untouched ng-pristine ng-valid ng-star-inserted" value=​"AND">​…​</select>​ <select name=​"operation" id=​"operation" formcontrolname=​"operation" class=​"form-control ng-untouched ng-pristine ng-valid ng-star-inserted" value=​"AND">​…​</select>​

Found 3 elements with non-unique id #query: (More info: https://goo.gl/9p2vKq) <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​ <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​ <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​

/explore/fundings_and_projects

Found 3 elements with non-unique id #filter: (More info: https://goo.gl/9p2vKq) <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​ <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​ <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​

Found 2 elements with non-unique id #operation: (More info: https://goo.gl/9p2vKq) <select name=​"operation" id=​"operation" formcontrolname=​"operation" class=​"form-control ng-untouched ng-pristine ng-valid ng-star-inserted" value=​"AND">​…​</select>​ <select name=​"operation" id=​"operation" formcontrolname=​"operation" class=​"form-control ng-untouched ng-pristine ng-valid ng-star-inserted" value=​"AND">​…​</select>​

Found 3 elements with non-unique id #query: (More info: https://goo.gl/9p2vKq) <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​ <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​ <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​

/explore/researchoutputs

Found 3 elements with non-unique id #filter: (More info: https://goo.gl/9p2vKq) <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​ <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​ <select name=​"filter" id=​"filter" formcontrolname=​"filter" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value=​"all">​…​</select>​

Found 2 elements with non-unique id #operation: (More info: https://goo.gl/9p2vKq) <select name=​"operation" id=​"operation" formcontrolname=​"operation" class=​"form-control ng-untouched ng-pristine ng-valid ng-star-inserted" value=​"AND">​…​</select>​ <select name=​"operation" id=​"operation" formcontrolname=​"operation" class=​"form-control ng-untouched ng-pristine ng-valid ng-star-inserted" value=​"AND">​…​</select>​

Found 3 elements with non-unique id #query: (More info: https://goo.gl/9p2vKq) <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​ <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​ <input type=​"text" name=​"query" id=​"query" formcontrolname=​"query" class=​"form-control mr-2 ng-untouched ng-pristine ng-valid" value>​
saschaszott commented 1 year ago

This issue has to be moved to the angular project. I'll close this tickets and open a new one in the angular project.