4Science / DSpace

This repository contains the 4Science optimized DSpace & DSpace-CRIS distribution.
https://wiki.lyrasis.org/display/DSPACECRIS/
BSD 3-Clause "New" or "Revised" License
42 stars 61 forks source link

quantify metadatavalues not to exposure the orcid authentication date #400

Open floriangantner opened 10 months ago

floriangantner commented 10 months ago

Is your feature request related to a problem? Please describe. In the migration procedure from DSpace 5.10 to Dspace7 the metadatafield dspace.orcid.authenticated field is filled with boolean values like https://github.com/4Science/DSpace/blob/bf5b19b6da561a9fc2e088dc1b376987c8115760/dspace/etc/migration/orcid_history_migration.ktr#L996

New successful linked profiles will get the date of the authentication https://github.com/4Science/DSpace/blob/bf5b19b6da561a9fc2e088dc1b376987c8115760/dspace-api/src/main/java/org/dspace/orcid/service/impl/OrcidSynchronizationServiceImpl.java#L105

The only usage we found is in the metadata-link-view.component.ts to show the orcid when the person is authenticated https://github.com/4Science/dspace-angular/blob/f5553efe4047fbdef0c667f0b28f1ee8f45930aa/src/app/shared/metadata-link-view/metadata-link-view.component.ts#L116C1-L116C1

Describe the solution you'd like

In our point of view this date is some sensitive data from some interaction between the researcher and some external system. This date is useful for administrators - we must admin - but has no real value for anonymous users.

We wonder if there might be some mechanisms which quantifies values, e.g. return some boolean for the existence of the metadata instead. This might be included in the MetadataSecurityService and be configurable on certain metadatafields

Describe alternatives or workarounds you've considered in case all your orcids are authenticated and you do not collect unauthenticated orcids this can be fixex on the frontend side by changing the above linked metadata-link-view.component

Additional context Add any other context or screenshots about the feature request here.