floriangantner
commented
6 months ago Bug still exists in 2023.02.02 - aligned to 2023.02.02 release
Closed floriangantner closed 1 month ago
floriangantner
commented
6 months ago Bug still exists in 2023.02.02 - aligned to 2023.02.02 release
floriangantner
commented
1 month ago fixed by some more extended translation solution in 2023.02.05
References
Add references/links to any related issues or PRs. These may include: superseeds
Description
The metadatafield label of metadata groups is currently translated wrong. According to the autogenerated i18n Keys in the layout.xls the Scheme
"layout.field.label.<EntityType>.<Metadatafield>": "<Value of Translation>"should work, but instead the translation for the value"layout.field.label.<Label of Metadatafield>"is being requested.Alternative way of solving this issue: This issue could also be solved purely by configuration with changing the layout.xls$metadatagroups column Label to .. In this case the formula in the metadatagroup_i18n sheets is calculated wrong and could be changed. Since diffs in the excel file are hard to read, we prefer the first approach ;)
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
Checklist
change default translation key being requested including the Item's entity Type and the name of the metadatafield
[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using
yarn run lint[ ] My PR doesn't introduce circular dependencies
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new, third-party dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.