search

4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
14 stars 28 forks source link

search labels not translated #12

Open floriangantner opened 1 year ago

floriangantner commented 1 year ago

Describe the bug The applied search filter labels in the badges above the search results are not translated correctly.

To Reproduce

  1. apply some filter with known translation https://dspacecris7.4science.cloud/search?page=1&configuration=researchoutputs&query=&f.has_content_in_original_bundle=true,equals&spc.page=1
  2. switch to locale de
  3. in the badge "true" is displayed Screenshot 2022-12-09 at 09-47-13 DSpace Angular Suche

Expected behavior

  1. We expect the existing values from the language json to be translated 4https://github.com/4Science/dspace-angular/blob/730fb8b90b8cb4960efbf5b763e6dff0010dddac/src/assets/i18n/de.json5#L4480 https://github.com/4Science/dspace-angular/blob/730fb8b90b8cb4960efbf5b763e6dff0010dddac/src/assets/i18n/de.json5#L4481 
    "search.filters.has_content_in_original_bundle.true": "Ja",

Related work PR will follow soon... Either normalize the value and also replace ,equals or rename the keys to scheme: search.filters.has_content_in_original_bundle,equals.true