normalize value for search label translation

floriangantner commented 1 year ago

References

Fixes https://github.com/4Science/dspace-angular/issues/12

Description

normalize filter value for translation of applied search labels

Instructions for Reviewers

List of changes in this PR:

remove double stripped/normalized Filter method
apply normalization for translation keys

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[ ] My PR doesn't introduce circular dependencies
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

floriangantner commented 6 months ago

aligned to 2023.02.02 Release - removed double normalization of FilterValue

floriangantner commented 1 month ago

in my opinion the improvement can also be applied tot 2023.02.02 upward releases

4Science / dspace-angular