Closed floriangantner closed 7 months ago
Describe the bug The counters component on the explore/site pages impacts general user experience because it's performance is poor to the non-usage of internal routing.
To Reproduce Visit the demo page. https://dspacecris7.4science.cloud/home Go to counters bar/row. Click any counter
site is reloaded because no internal route is set.
Expected behavior no reload of page when switching to the explore pages.
Related work Might open some PR in future to this issue with our working solution to this issue if i have time.
Conclusion: https://github.com/4Science/dspace-angular/blob/dspace-cris-7/src/app/shared/explore/section-component/counters-section/counters-section.component.ts goToLink(...) might be replaced with router.navigateByUrl() or some [routingLink] might be added to the links considering the url and additional considering possible queryParams.
goToLink(...)
router.navigateByUrl()
meanwhile superseded by similar commit https://github.com/4Science/dspace-angular/commit/c1c5a6639703d3502dd3c1fe85d4d6ef0ef5f24c#diff-fa2b04cc8f2b5b8a618883582c9320466bdc4c36f1f14506164744cefe370f1f
floriangantner
commented
7 months ago
Describe the bug The counters component on the explore/site pages impacts general user experience because it's performance is poor to the non-usage of internal routing.
To Reproduce Visit the demo page. https://dspacecris7.4science.cloud/home Go to counters bar/row. Click any counter
Expected behavior no reload of page when switching to the explore pages.
Related work Might open some PR in future to this issue with our working solution to this issue if i have time.
Conclusion: https://github.com/4Science/dspace-angular/blob/dspace-cris-7/src/app/shared/explore/section-component/counters-section/counters-section.component.ts
goToLink(...)might be replaced withrouter.navigateByUrl()or some [routingLink] might be added to the links considering the url and additional considering possible queryParams.