Fix error message when updating ORCID settings

[enea4science]

References

None

Description

When a researcher tries to update their ORCID settings, an error message (“The update of the synchronization settings failed”) appears. Indeed REST call returned a 200 response code and settings are actually saved.

This PR fixes that by changing the response condition from isSuccess to hasSucceeded as the last one checks for 'success' and 'successStale'.

Checklist

• [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• [x] My PR passes TSLint validation using yarn run lint
• [x] My PR doesn't introduce circular dependencies
• [x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• [x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• [x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[corrad82-4s]

To be open against DSpace/main if not already done