search

4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
14 stars 28 forks source link

Browse by authority and back does not show the previous result #22

Open floriangantner opened 1 year ago

floriangantner commented 1 year ago

Describe the bug Browsing after some Item with authority does not return to the previous state.

To Reproduce Steps to reproduce the behavior:

  1. Configure some Browse Option which considers authority values.
  2. e.g. visit Demo: https://dspacecris7.4science.cloud/browse/author
  3. Select some browse entry with value and authority , e.g. https://dspacecris7.4science.cloud/browse/author?value=Bollini,%20Andrea&authority=092b59e8-8159-4e70-98b5-93ec60bd3431

Screenshot 2023-04-14 at 17-43-14 DSpace Angular Auflistung nach Autor in

  1. Screenshot 2023-04-14 at 17-43-25 DSpace Angular Auflistung nach Autor in

  2. Press the Back buttons. the URL changes:

  3. Not the previous results are shown, but some corrupt list of all entities. The URL is now: https://dspacecris7.4science.cloud/browse/author?authority=092b59e8-8159-4e70-98b5-93ec60bd3431&bbm.page=1 Screenshot 2023-04-14 at 17-43-33 DSpace Angular Auflistung nach Autor in

Expected behavior We expect the route to be updated and the parameter authority to be removed. The corresponding line is this: https://github.com/4Science/dspace-angular/blob/4ece4cd6d36c2bcd11774d8efea8083ba52d7069/src/app/shared/browse-by/browse-by.component.ts#L192

Related work Link to any related tickets or PRs here.

floriangantner commented 1 month ago

still reproduce-able in current 2023.02.xx releases f.e. fpr 2023.02.04 currently see https://dspacecris-demo.4science.cloud/browse/author?value=Bollini,%20Andrea&authority=092b59e8-8159-4e70-98b5-93ec60bd3431 and press back to results