4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

Browse-By pages are not working #51

Closed olli-gold closed 10 months ago

olli-gold commented 10 months ago

Describe the bug The Browse-By pages, which are linked from explore pages like https://dspacecris7.4science.cloud/explore/fundings_and_projects, are not working any longer on DSpace-CRIS 2023.01.00. It worked fine on DSpace-CRIS 2022.03.01.

To Reproduce The problem is reproducable on the official DSpace-CRIS demo page.

  1. Go to https://dspacecris7.4science.cloud/explore/fundings_and_projects
  2. Click on Browse/Title
  3. You will see an infinite loading loop and on the console you will see an error message like this:
    ERROR Error: Uncaught (in promise): TypeError: H is null
    getCommonMenu@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:1281640
    getDsoMenus@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:1281586
    10217/resolve/B<@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:1281229
    21160/l/</<@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:3223165
    58886/i/this._next<@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:3215159
    next@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:3203908
    77176/l/</<@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:3223442
    58886/i/this._next<@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:3215159
    next@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:3203908
    77007/i/</<@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:3217853
    58886/i/this._next<@https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1:3215159
    next@https://dspacecris7.4science.clo…
    _t https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    _t https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    nr https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    invokeTask https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    onInvokeTask https://dspacecris7.4science.cloud/main.077d808c488a62c8.js:1
    invokeTask https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    runTask https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    it https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    invokeTask https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    q https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    ut https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1
    pt https://dspacecris7.4science.cloud/polyfills.21d33572cec4a4e1.js:1

Expected behavior The browse-by-page should appear on the screen.

Related work None I am aware of

olli-gold commented 10 months ago

I just noticed, that there actually was some related work on that in form of an issue (#30) and there is a commit https://github.com/DSpace/dspace-angular/commit/23b5d52623aceefa7d98e701c1cb34955a15d456 referenced, which resolves the issue. I have applied the commit and can confirm, that it solves this problem. So I am going to close this ticket in favor of #30.