search

4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

markdown preview loads external dependencies #58

Closed floriangantner closed 1 week ago

floriangantner commented 7 months ago

Describe the bug The markdown preview plugin https://github.com/4Science/dspace-angular/blob/6b657f5252cfb97ddf248aaae399be98915c71f5/src/app/shared/markdown-viewer/markdown-viewer.component.html#L1
loads external dependencies from cdn pages.

To Reproduce Steps to reproduce the behavior:

  1. Call https://dspacecris7.4science.cloud/info/end-user-agreement
  2. Check the network connections. dependencies are loaded from the https://www.npmjs.com/package/@ng-util/markdown dependy

Screenshot from 2023-12-07 12-59-02

Expected behavior We expect the dependencies being loaded from the site and not from external cdn's.

Related work Similar issue with google Fonts (removed in 7.6): https://github.com/DSpace/dspace-angular/issues/2077

floriangantner commented 1 week ago

fixed in 2023.02.04