search

4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
14 stars 28 forks source link

Importing from external sources - pagination fail #59

Open floriangantner opened 10 months ago

floriangantner commented 10 months ago

When importing from external sources in DSpace-Cris (e.g. crossref or datacite) the pagination does not work.

To Reproduce Steps to reproduce the behavior:

  1. Import something from some external source, e.g. datacite DOI 10.5281/zenodo with more than 10 results to be expect
  2. try to navigate between the results using the pagination
  3. the results list will keep the same, but the pagination (pages, number of changes) will change. There are no further requests when the pages change.

Expected behavior We expect to paginate over external source entries . This works smooth on the standard DSpace Demo.

Thus we locate the problem at https://github.com/4Science/dspace-angular/blob/f5d618f093ce80506e49d799c0d4c6061586d598/src/app/submission/import-external/submission-import-external.component.ts#L119C6-L119C6 adding some this.searchConfigService.setPaginationId(this.initialPagination.id); to the init method will surely fix the problem, because the searchOptions requested when getting the external source entries returns the setting from the 'spc' configuration and not the uuid settings.

Related work Link to any related tickets or PRs here.