Metadatagroup field label being translated wrong

[floriangantner]

References

Add references/links to any related issues or PRs. These may include:

• Fixes #[issue-number]
• Requires DSpace/DSpace#[pr-number] (if a REST API PR is required to test this)

Description

The metadatafield label of metadata groups is currently translated wrong. According to the autogenerated i18n Keys in the layout.xls the Scheme "layout.field.label.<EntityType>.<Metadatafield>": "<Value of Translation>" should work, but instead the translation for the value "layout.field.label.<Label of Metadatafield>" is being requested.

Alternative way of solving this issue: This issue could also be solved purely by configuration with changing the layout.xls$metadatagroups column Label to .. In this case the formula in the metadatagroup_i18n sheets is calculated wrong and could be changed. Since diffs in the excel file are hard to read, we prefer the first approach ;)

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

• change default translation key being requested including the Item's entity Type and the name of the metadatafield

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• [x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• [x] My PR passes TSLint validation using yarn run lint
• [ ] My PR doesn't introduce circular dependencies
• [ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• [ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• [ ] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[atarix83]

@floriangantner there is a lint error, could you fix before we'll merge the PR ? thanks

[floriangantner]

@atarix83 sorry for the late response, the lint error is now fixed :)