search

4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
14 stars 28 forks source link

bulk import with wrong parameter #69

Open floriangantner opened 8 months ago

floriangantner commented 8 months ago

Describe the bug The bulk import uses the wrong parameter on the "Abort-on-first-error" option

https://github.com/4Science/dspace-angular/blob/c1c5a6639703d3502dd3c1fe85d4d6ef0ef5f24c/src/app/bulk-import/bulk-import-page.component.ts#L95

It uses -e which is not present in the bulk-import Script Configuration

To Reproduce Steps to reproduce the behavior:

  1. Collection -> Import items into collection >
  2. check abort on first and trigger process
  3. See process output. Parameter should be missing.

Expected behavior We expect the correct parameter to be called which is the -er option instead.

https://github.com/4Science/DSpace/blob/2433b9bbbe6b3d0f2867a88e805da1f299f456a2/dspace-api/src/main/java/org/dspace/app/bulkedit/BulkImportScriptConfiguration.java#L55

Related work

floriangantner commented 2 months ago

still existent in 2023.02.05