own component for link with icon (mainly using logic from LinkMenuItemModel)
explore-section-navigation uses new component instead of lint component
icons definable in Messages
If no i18n key is provided, only the title is shown.
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[] My PR passes TSLint validation using yarn run lint
[ ] My PR doesn't introduce circular dependencies
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
References
Add references/links to any related issues or PRs. These may include:
Description
Working state of our implementation of navigation icons as presented and discussed at the Cris working group meeting 2022-04-05 (https://docs.google.com/document/d/1NJvUtDwKymY1hhxtcT_wjQvzx4pZlJcf0xICz5LRsq0) Still a draft, because tests are missing.
Connected to open backend:
Instructions for Reviewers
List of changes in this PR:
LinkMenuItemModel)Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.