4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

collection browse search results might show loader #70

Open floriangantner opened 5 months ago

floriangantner commented 5 months ago

Describe the bug If no browse index is configured for someCollection and dc.date.accessioned is not configured as some sorting in the default/common configuration the sorting for some collection browse will always show the loader.

To Reproduce Steps to reproduce the behavior:

  1. Configure browse.collection.Publication = and browse.collection =
  2. remove sortDateAsseccioned from defaultConfiguration or commonConfiguration.
  3. Call collection page

Screenshot 2024-02-07 at 16-41-41 Publications

Expected behavior Dear reader of this issue, do not pay too much attention to our above mentioned configuration. We expect the browsing showing some error message when the retrieved searchresults from the search endpoint contains some error and not continously showing the loader.

This can be achieved by some check of the response here: https://github.com/4Science/dspace-angular/blob/359ddec66158e33721f57c34fd210a4adb111cca/src/app/collection-page/collection-page.component.ts#L124

Apart from that it would be some nice feature to have the ability to disable the recent submission on the collection page by some environment setting, but this is not part of this issue.

Related work

Link to any related tickets or PRs here.