4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
13 stars 28 forks source link

adds version information to CRIS item page #75

Open olli-gold opened 4 months ago

olli-gold commented 4 months ago

References

Description

This PR adds the missing version information to the CRIS item page if applicable.

Effectively, it adds a notice about an existing newer version of the item on itempages for an old version and a version history information on any itempage handling a versioned item.

grafik grafik

Instructions for Reviewers

This PR integrates the reference to a new version and the version history to CRIS item pages. To review, create a versioned item and view the item page. On the item page of the old version, there should be a reference to the new version. On any item page involved with the versioned item, the version history should be shown.

You can also find a live example on https://doi.org/10.15480/336.2396.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

z-stoynova commented 4 months ago

I have tested this PR and I can confirm that the version table in all version Items and the link to the latest version in all previous item is added and shown:

image

image

image

The link to the latest version in the last screenshot is properly generated.

However we noticed that the links to the version Items in the version table (host-url/items/version/versionId) cannot be resolved by the backend and a 404 (Not Found) Error is returned.This is explicitely described in issue dspace-angular#67.

The suggested code in this PR does exactly what is described but the desribed version link problem shows that there is an underlying bug in the generation of item version links. This was tested with dspce-cris-2023.02.02.