Closed floriangantner closed 2 years ago
Hello @floriangantner , thank you very much for this interesting PR and for the work done for this feature. We are working on a similar feature, supported by TUHH. However, after some analysis, we have decided to and are implementing our logic, returning only metadata values in required language (or in a fallback one, if required is not available), on REST side instead of angular. Thank you again.
References
Add references/links to any related issues or PRs. These may include:
Description
Working state of our implementation of multilingualism as presented and discussed at the Cris working group meeting 2022-04-05 (https://docs.google.com/document/d/1NJvUtDwKymY1hhxtcT_wjQvzx4pZlJcf0xICz5LRsq0) Not sure, if multilingualism is the correct term in this context to distinguish it from the i18n translation. Still a draft, because tests are missing.
Instructions for Reviewers
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
textmultilingual
rendering For Example given (place of Metadata should matter): dc.title::it_ITdc.title::en_EN
dc.title::de_DE
dc.title::en_EN
dc.title
dc.title ::it_IT
Effects / Use Cases:
Display of general Search-Result-Lists (and possible other benefits like the breadcrumb, page title etc...)
locale de: (first result has dc.title in de_DE and en_EN)
locale en:
Display of Cris Layout (f.e. leading tab)
locale de:
locale en:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lint
package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.