4Science / dspace-angular

Angular UI for DSpace and DSpace-CRIS. In the dspace-cris-7 branch you can find the extension to support DSpace-CRIS
BSD 3-Clause "New" or "Revised" License
14 stars 28 forks source link

Multilingual entity titles #8

Closed floriangantner closed 2 years ago

floriangantner commented 2 years ago

References

Add references/links to any related issues or PRs. These may include:

Description

Working state of our implementation of multilingualism as presented and discussed at the Cris working group meeting 2022-04-05 (https://docs.google.com/document/d/1NJvUtDwKymY1hhxtcT_wjQvzx4pZlJcf0xICz5LRsq0) Not sure, if multilingualism is the correct term in this context to distinguish it from the i18n translation. Still a draft, because tests are missing.

Instructions for Reviewers

List of changes in this PR:

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

locale defaultlocale shown value
it en dc.title::it_IT
de en dc.title::de _DE
ru en dc.title::en_EN
dc.title::it_IT
dc.title::en_EN
dc.title
locale defaultlocale shown value
it en dc.title::it_IT
ru en dc.title::en_EN
de en dc.title::en_EN
dc.title
dc.title ::it_IT
locale defaultlocale shown value
it en dc.title::it_IT
ru en dc.title
en en dc.title

Effects / Use Cases:

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

corrad82-4s commented 2 years ago

Hello @floriangantner , thank you very much for this interesting PR and for the work done for this feature. We are working on a similar feature, supported by TUHH. However, after some analysis, we have decided to and are implementing our logic, returning only metadata values in required language (or in a fallback one, if required is not available), on REST side instead of angular. Thank you again.