Open RubendeBruin opened 2 months ago
Hi, can you explain a bit more?
sorry, updated the comment.
If a the dirs are defined in degrees then this function fails because it checks if dirs[-1] >= 2.0 * pi.
I think the function should check whether the definition is in degrees or radians and then check the maximum value accordingly.
I believe that we always convert to radians, even though the user provides directions in degrees, see the init method. Hence I don't think that is necessary. We should probably remove the degrees part of the error message
_check_dirs fails if largest direction >= 2.0*pi but according error message this should be 360