search

4a2e532e / RealisticSwimming

A bukkit plugin that makes swimming look more 'realistic'
MIT License
14 stars 3 forks source link

Bugfixes, Full Compatibility with Elytra Plugin #8

Closed DrkMatr1984 closed 7 years ago

DrkMatr1984 commented 7 years ago

Fix Bossbar so it actually updates, bump version on BossBarAPI, add class to provide full compatibility with Elytra Plugin (https://www.spigotmc.org/resources/elytra.19284/), fix armor weight still being sent if entering water and armor weight disabled(if announceweight was still true, it sent the weight anyway)

4a2e532e commented 7 years ago

I really appreciate your efforts to make RealisticSwimming compatible with AAC but it is also very important to me that everyone is able to compile RealisticSwimming from source. That means all dependencies required for building have to be available to everyone free of charge.

I am sorry but I can't merge your pr because it would make it impossible to compile RealisticSwimming without purchasing AAC.

DrkMatr1984 commented 7 years ago

Yeah I thought about it after I made the pr. I am going to compile a second plugin that will provide compatibility and simply add a hook to your plugins onenable method that checks for my compatibility plugin and hooks into it. After that I can just add updates into my own plugin for any incompatibilities people report and if I give it a decent api realistic swimming will only require my next pr as an update to be able to handle the compatibility.