4am-robotics / cob_common

The cob_common stack hosts common packages that are used within the Care-O-bot repository. E.g. utility packages or common message and service definitions etc. Also the urdf desciption of the robot is located in this stack.
https://mojin-robotics.de/
Apache License 2.0
66 stars 136 forks source link

add cob_actions #263

Closed fmessmer closed 5 years ago

fmessmer commented 5 years ago

we've had a need for such basic actions every now and then, and such actions are not available within actionlib....feel free to use them

ipa-rmb commented 5 years ago

Awesome, I tried to add something similar to std_srvs but it was refused: https://github.com/ros/ros_comm_msgs/pull/9

fmessmer commented 5 years ago

well, I added actions but your services should be available in cob_srvs...

ipa-rmb commented 5 years ago

If they are needed, I will put all the formerly proposed services there. I was fine with the datatypes already present in cob_srvs. I just wanted to mention that I am happy that our reasoning does not exclude "meaningless" SetDatatype action and service messages.