4am-robotics / cob_common

The cob_common stack hosts common packages that are used within the Care-O-bot repository. E.g. utility packages or common message and service definitions etc. Also the urdf desciption of the robot is located in this stack.
https://mojin-robotics.de/
Apache License 2.0
66 stars 136 forks source link

humble release #302

Closed christian-rauch closed 10 months ago

christian-rauch commented 10 months ago

Are there plans to release this via bloom for humble to the Debian repo?

fmessmer commented 10 months ago

no plans to release into ros2 so far, but also no argument against it cob_common only has a foxy branch which only provides "some" of the packages to ros2 and COLCON_IGNOREs other as they are not yet ported

@christian-rauch which packages are you interested in? did you test foxy branch with humble distro?

if you can confirm what you need is available in the foxy branch and does work for humble, I can do the bloom-release step for humble

christian-rauch commented 10 months ago

no plans to release into ros2 so far, but also no argument against it cob_common only has a foxy branch which only provides "some" of the packages to ros2 and COLCON_IGNOREs other as they are not yet ported

As far as I can see, colcon list lists all packages in this repo:

cob_actions src/cob_common/cob_actions  (ros.ament_cmake)
cob_common  src/cob_common/cob_common   (ros.ament_cmake)
cob_description src/cob_common/cob_description  (ros.ament_cmake)
cob_msgs    src/cob_common/cob_msgs (ros.ament_cmake)
cob_srvs    src/cob_common/cob_srvs (ros.ament_cmake)
raw_description src/cob_common/raw_description  (ros.ament_cmake)

I assume all of cob_common is supported? Or am I missing something?

@christian-rauch which packages are you interested in? did you test foxy branch with humble distro?

if you can confirm what you need is available in the foxy branch and does work for humble, I can do the bloom-release step for humble

I am mainly interested in the message definitions, i.e. packages cob_msgs, cob_srvs and cob_actions.

However, most of the actions (SetString, SetInt, SetFloat) are redundant as they already exist as services and services can run asynchronously in ROS 2, and SetBool could also be turned into a service. Is someone actively using those actions or could we remove them and replace the SetBool action by a service?

fmessmer commented 10 months ago

no plans to release into ros2 so far, but also no argument against it cob_common only has a foxy branch which only provides "some" of the packages to ros2 and COLCON_IGNOREs other as they are not yet ported

As far as I can see, colcon list lists all packages in this repo:

cob_actions   src/cob_common/cob_actions  (ros.ament_cmake)
cob_common    src/cob_common/cob_common   (ros.ament_cmake)
cob_description   src/cob_common/cob_description  (ros.ament_cmake)
cob_msgs  src/cob_common/cob_msgs (ros.ament_cmake)
cob_srvs  src/cob_common/cob_srvs (ros.ament_cmake)
raw_description   src/cob_common/raw_description  (ros.ament_cmake)

I assume all of cob_common is supported? Or am I missing something?

ah, right...I thought we only migrated the packages we currently use under ROS2...but obviously all have been migrated to ROS2 - at least they compile....we are not actively using those (*_description) packages in ROS2 - actually not even tested them whether they do anything useful ;-)

@christian-rauch which packages are you interested in? did you test foxy branch with humble distro? if you can confirm what you need is available in the foxy branch and does work for humble, I can do the bloom-release step for humble

I am mainly interested in the message definitions, i.e. packages cob_msgs, cob_srvs and cob_actions.

However, most of the actions (SetString, SetInt, SetFloat) are redundant as they already exist as services and services can run asynchronously in ROS 2, and SetBool could also be turned into a service. Is someone actively using those actions or could we remove them and replace the SetBool action by a service?

If you are ok with the current status of cob_msgs, cob_srvs and cob_actions, I'm going to release only those packages to humble for now - and ignore the others in the respective humble.ignored file in the release repo

:point_right: https://github.com/ipa320/cob_common-release/commit/4b59f02578d74992299550ef4217525ff6fed0e5

fmessmer commented 10 months ago

that should be it https://github.com/ros/rosdistro/pull/38899

@christian-rauch I'll close here - please re-open once you experience issues with the binaries once the packages is available after the next sync