[cob_phidgets][cob_light] Critical compiler warnings in phidgets and lights

4am-robotics / cob_driver

The cob_driver stack includes packages that provide access to the Care-O-bot hardware over ROS messages and services. E.g. for mobile base, arm, camera_sensors, scanners, etc...

www.care-o-bot.org

Apache License 2.0

102 stars 164 forks source link

[cob_phidgets][cob_light] Critical compiler warnings in phidgets and lights #224

Closed benmaidel closed 7 years ago

benmaidel commented 9 years ago

This compiler warnings should get fixed:

cob_phigets
- implicit conversion from 'double' to 'unsigned int' changes value from 0.5 to 0
cob_light
- control reaches end of non-void function (no return value)
- control reaches end of non-void function (no return value)

benmaidel commented 9 years ago

@ipa-bnm

fmessmer commented 9 years ago

Also have a look at these (minor) catkin_lint hints:

cob_phidgets: CMakeLists.txt(8): notice: line is not indented properly
cob_phidgets: CMakeLists.txt(14): notice: extra arguments in else()
cob_phidgets: CMakeLists.txt(16): notice: extra arguments in endif()

fmessmer commented 8 years ago

@ipa-bnm any progress here?

fmessmer commented 7 years ago

forget about catkin_lint done in #314