search

4am-robotics / cob_driver

The cob_driver stack includes packages that provide access to the Care-O-bot hardware over ROS messages and services. E.g. for mobile base, arm, camera_sensors, scanners, etc...
www.care-o-bot.org
Apache License 2.0
102 stars 164 forks source link

[cob_light] Handling `sim_enabled` param in simulation #236

Closed fmessmer closed 8 years ago

fmessmer commented 9 years ago

See my comments about "Warning B" in https://github.com/ipa320/cob_simulation/issues/87#issuecomment-132086878

So far, we are using the same yaml for simulation and real hardware. This leads to the following warning:

[ WARN] [1439833261.548182269]: Serial connection on /dev/ttyLed failed.

In that yaml sim_enabled is set to false...thus, in simulation you cannot actually use sim_enabled

Maybe we should make it a private parameter that can be set via launch file argument in https://github.com/ipa320/cob_robots/blob/indigo_dev/cob_bringup/drivers/light.launch?

@ipa-bnm what do you think?

fmessmer commented 9 years ago

As `sim_enabled already is a private parameter....https://github.com/ipa320/cob_robots/pull/326 should fix the warning about failed serial connection in simulation

benmaidel commented 9 years ago

as already in ipa320/cob_robots#326 commented, this is ok!