ROS_PYTHON_VERSION conditional dependency for `python-tk` and `python-numpy`

4am-robotics / cob_driver

The cob_driver stack includes packages that provide access to the Care-O-bot hardware over ROS messages and services. E.g. for mobile base, arm, camera_sensors, scanners, etc...

www.care-o-bot.org

Apache License 2.0

102 stars 164 forks source link

ROS_PYTHON_VERSION conditional dependency for `python-tk` and `python-numpy` #423

Closed mikaelarguedas closed 3 years ago

mikaelarguedas commented 3 years ago

Introspecting Python 2 dependencies in ROS Noetic, found that this package depends on python-tk and python-numpy instead of its python3 counterpart.

This PR makes the dependency conditional on the ROS_PYTHON_VERSION. SImilar to https://github.com/ipa320/cob_command_tools/pull/302

This is a semi-automated PR that has not been tested

mikaelarguedas commented 3 years ago

oh yeah totally missed updating the package format of that one. updated in https://github.com/ipa320/cob_driver/pull/423/commits/f25a9d75cddd3649cce5145008c53b72cbcd957d

fmessmer commented 3 years ago

@mikaelarguedas as a side question: do you need me to trigger a new releases soon? i.e. is the python-* (python2) dependency causing any issues on the build farm? or where did you observe issues that made you propose these changes?

mikaelarguedas commented 3 years ago

do you need me to trigger a new releases soon? i.e. is the python-* (python2) dependency causing any issues on the build farm?

it's independant from the buildfarm so no rush. I was just wondering why python 2 kept getting installed on my machines, after fixing a couple packages I was using I decided to report or fix all the noetic packages that were installing python2 to avoid having surprises in the future. But I am not currently using any of the cob packages.