Added temporary patch for WebSocket

4as / ChatGPT-DeMod

Tampermonkey/Greasemonkey script that hides the moderation results when communicating with ChatGPT.

GNU General Public License v2.0

421 stars 59 forks source link

Added temporary patch for WebSocket #39

Closed e39a562r closed 9 months ago

e39a562r commented 10 months ago

Here are some changes I made for myself to avoid issue #38.

It has a problem I've no idea how to workaround, so...

Please merge it only when it really saves your time. 🙏

Changes

Skip inner loop of ConversationType.PROMPT when the response data is an url of websocket.
Replace the value blocked flag from true to false for every websocket message.

Problems

Unable to fetch latest conversation for user when the message is blocked, due to unable to intercept websocket with asynchronous function.

Cause of the issue #38

ChatGPT responsing conversation with only an url of websocket

4as commented 10 months ago

Thank you for handling this issue.
For now I am yet to run into the same problem, so I can't yet verify whether this fix works or not. As soon as they roll out the changes to my region I'll take a look and do a review.
In the mean time can you confirm that your changes also handle yellow and red warnings? Also does the fix work on iOS (Safari with UserScripts) and Android (KiwiBrowser)?

e39a562r commented 10 months ago

Uh I just install Kiwi Browser (what a nice app) on my android, and ...... it is not affected by issue #38 ! 😂

Now I also have to wait. 🤣🤣🤣

Updates

Snooze yellow warnings from websocket message.

Todo

[ ] Test this branch on iOS device, (find an iOS device first)
[ ] Wait until the bug happen on my android Kiwi Browser.

e39a562r commented 10 months ago

The problem is disappeared. 🚀

ysy95109 commented 9 months ago

This solves the recent issue 38.

4as commented 9 months ago

In the latest update to DeMod I've added changes that I think resolve the issue related to this pull request, so I'm closing it, as it's probably no longer needed.