search

4ch1m / mozext

Extensions / Add-Ons for Mozilla Firefox and Mozilla Thunderbird
https://www.achimonline.de/mozext
Mozilla Public License 2.0
20 stars 9 forks source link

Document auto switch email addresses have to be escaped #36

Closed hokascha closed 3 years ago

hokascha commented 3 years ago

When adding a signature that has an auto switch filter for domain endings, for example: "@.com" the dot has to be escaped like in "@.com". Not escaping the dot will let every email address containg "com" trigger the switch - not only those containing ".com".

This should be documented or automatically escaped.

4ch1m commented 3 years ago

Right. That was a bug. => f004bb35a2bfa5aaa5bb08dfd92609ab426080c9 Will be fixed in next release.

hokascha commented 3 years ago

While fixing this, could you also make sure, the filter will not get double escaped? I suppose people are circumventing the bug like me and escape their dots. These should not be escaped again. As the backslash is not a valid part of an email address this should be safe.

4ch1m commented 3 years ago

No, sorry. This was a bug, and it has been fixed now. I'd like to keep the code simple and not add additional code just to handle externally applied workarounds. Should be easy/simple to correct this - as intended - via the UI.