search

4ch1m / pixoo-rest

A RESTful API to easily interact with the Wi-Fi enabled Divoom Pixoo devices.
MIT License
258 stars 17 forks source link

Image url #10

Closed kmplngj closed 1 year ago

kmplngj commented 1 year ago

I added a call to display an image from a url.

I use this to display cover art from the music playing on my HomePod.

4ch1m commented 1 year ago

@kmplngj, thank you for the contribution. :+1:

I had already decided in the past not to implement any "image download features" in this app (see #9).

However, I will have a look at your PR.

kmplngj commented 1 year ago

I added some more error handling.

4ch1m commented 1 year ago

@kmplngj I just created a new branch with a different implementation: download_endpoints

You may want to have a look at it. Should work for you as well.

kmplngj commented 1 year ago

Nice.

I would not split download image and download gif if it could be solved in one function. Perhaps you use an URL to download something that is just referenced per id parameters and you do not not the image before download.

4ch1m commented 1 year ago

The requested feature is now part of the current master-branch. @kmplngj, thanks for your help/feedback! :bow: