search

4chan / 4chan-API

Documentation for 4chan's read-only JSON API.
http://www.4chan.org/
1.02k stars 73 forks source link

Added board flag properties to comment props list #89

Closed catamphetamine closed 3 years ago

catamphetamine commented 3 years ago

You have added new properties but you have done it without updating the comment props list.

desuwa commented 3 years ago

Thanks! Before I merge this, can you remove the 2 character string part please? The new flag codes are 3 characters long for example and there probably won't be a character limit for this field.

catamphetamine commented 3 years ago

The new flag codes are 3 characters long

You mean new "troll" flags or you're transitioning from ISO 3166-1 alpha-2 to ISO 3166-1 alpha-3 for country flags?

catamphetamine commented 3 years ago

can you remove the 2 character string part

Should I put any string there?

desuwa commented 3 years ago

Should I put any string there?

Sure. Or leave it blank if you want.

You mean new "troll" flags.

Yes. Some of the new flags we added have a 3 characters long code.

catamphetamine commented 3 years ago

Cool. Corrected.