4d-go-mobile / formatter-Phone

When a phone number is clicked, open a menu to call the number or add a contact
Other
0 stars 1 forks source link

iOS 13.3 crashes when using formatter-Phone #1

Open mcamus opened 4 years ago

mcamus commented 4 years ago

When using formatter-phone for a phone field, the opening of a entity containing a such data crashes the iOS app, in Simulator or on an iPhone. Resetting the entity field format to text doesn't crash. Same for formatter-Mail with a mail field.

mesopelagique commented 4 years ago

Hi,

I look at the crash information

 name:NSUnknownKeyException 
 reason:Optional("[<UILabel 0x7fdefe51de10> valueForUndefinedKey:]: this class is not key value coding-compliant for the key phoneAction.") 

It seems to have key phoneAction. instead of phoneAction

I have tested it using last beta version (18R2 beta), I have no issue and the result in Xcode is when selecting the MaTableListForm.storyboard or MaTableDetailForm.storyboard and clicking the corresponding table field Screenshot 2020-03-18 at 16 21 48


I have created a new version maybe compatible with old release https://github.com/4d-for-ios/formatter-Phone/tree/old (by renaming a key in manifest de70a5a587d692fdb2691668416bd106c0d75743 )


And finally I ask QA team to check that.

hondrogiannis commented 4 years ago

Hi, I use 4D 18r2 I have the same crashes on the iPhone with iOS 13.4 and 13.4.1

When will this bug be fixed?

mesopelagique commented 4 years ago

Hi @hondrogiannis it work with my18R3 beta in preparation I think the issue is the name, github project for formatters has been commited for 18R3 in dev

So for 18R2 formatter-Phone folder must be renamed "phone" to inject swift code into final project

I have a working patched version in 18R2, I must wait the validation of quality team

hondrogiannis commented 4 years ago

Hi,

Thanks for the feedback.

formatter-Phone: I can confirm the workoround for phone formatter, iOS no longer crashes.

formatter-Mail: When using the mail format, iOS no longer crashes when I rename the folder to mail, but there is no email function.

regards Nikolaos Hondrogiannis

Am 14.04.2020 um 10:01 schrieb Eric Marchand notifications@github.com:

Hi @hondrogiannis https://github.com/hondrogiannis it work with my18R3 beta in preparation I think the issue is the name, github project for formatters has been commited for 18R3 in dev

So for 18R2 formatter-Phone folder must be renamed "phone" to inject swift code into final project

I have a working patched version in 18R2, I must wait the validation of quality team

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/4d-for-ios/formatter-Phone/issues/1#issuecomment-613288166, or unsubscribe https://github.com/notifications/unsubscribe-auth/APDGXGNA5ERC6JGXWBPSXW3RMQJ7LANCNFSM4LJOCKAQ.

mcamus commented 4 years ago

HI,

Thank you for your feed-back,

I will try very soon, ...;-)

Michel Camus

mcamus1@gmail.com

gsm: +212 670 06 13 85

" L'erreur ne devient pas verite parce qu'elle se propage et se multiplie; la verite ne devient pas erreur parce que nul ne la voit." Gandhi

Le mar. 14 avr. 2020 à 09:01, Eric Marchand notifications@github.com a écrit :

Hi @hondrogiannis https://github.com/hondrogiannis it work with my18R3 beta in preparation I think the issue is the name, github project for formatters has been commited for 18R3 in dev

So for 18R2 formatter-Phone folder must be renamed "phone" to inject swift code into final project

I have a working patched version in 18R2, I must wait the validation of quality team

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/4d-for-ios/formatter-Phone/issues/1#issuecomment-613288166, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM27PG4SAQISXSB67F6BCTRMQJ7JANCNFSM4LJOCKAQ .