4d / 4D-Mobile-App-Server

Open sourced component to install to 4d server as mobile app back end
Other
6 stars 7 forks source link

At least some push notification errors are not being returned #12

Open macMikey opened 2 years ago

macMikey commented 2 years ago

class PushNotification.send calls Mobile App Push Notification which calls apple_sendNotification. In line 38-42 we have

If (Length($cmdPush_err)>0)

    LOG EVENT(Into 4D debug message; $cmdPush_err)

End if 

but, we don't return $cmdPush_err up the chain, so the PushNotification.result property is never set with the error, etc.

I ran into this issue, today. I got warnings, including a warning that a push notification was not sent (but no error), and I did not get a reason returned, either.

mesopelagique commented 2 years ago

You could get link direct from the code with line in

I think you talk about this log https://github.com/4d/4D-Mobile-App-Server/blob/main/Project/Sources/Methods/apple_sendNotification.4dm#L49

The $cmdPush_err is filled by LAUNCH EXTERNAL PROCESS

https://github.com/4d/4D-Mobile-App-Server/blob/main/Project/Sources/Methods/apple_sendNotification.4dm#L45