search

4d / 4D-Mobile-App-Server

Open sourced component to install to 4d server as mobile app back end
Other
6 stars 7 forks source link

push only accepts email addresses for devices #7

Open macMikey opened 2 years ago

macMikey commented 2 years ago

Push is device-dependent, but sometime after b27545ffb08b684f7212f869f04e000d868e1ed3 (I have not dug into the code to discover where, yet), it became email-dependent. This might be fine for cases where only a personal device is being used, but it does not work at all for kiosks, where multiple people use the same device and the same person can be on multiple devices throughout the day. In our case, we have the devices named, but the push code is now rejecting device names that are not email addresses.

macMikey commented 2 years ago

In 19.1, it works as expected. 18R4 breaks it.

macMikey commented 2 years ago

Looks like this is from the change you made in buildRecipients between R3 and R4.

mesopelagique commented 2 years ago

1dc012df6d9a77fc8ccc9355807793daf5fb1f0d ?

macMikey commented 2 years ago

The commit id. Regardless, I backtracked through the commits, since your branches abd repos aren't contiguous, and I'm pretty sure this is new in R4. I'll look into it when I get a chance.

On Thu, Jan 13, 2022, 16:59 Eric Marchand @.***> wrote:

1dc012d https://github.com/4d-go-mobile/4D-Mobile-App-Server/commit/1dc012df6d9a77fc8ccc9355807793daf5fb1f0d ?

— Reply to this email directly, view it on GitHub https://github.com/4d-go-mobile/4D-Mobile-App-Server/issues/7#issuecomment-1012549189, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACS5CSHOZ5K3HLS7IZR5KXDUV5DMZANCNFSM5L4IA74Q . You are receiving this because you authored the thread.Message ID: @.***>

macMikey commented 2 years ago

Are you sure the R4 version of the component is in the repo? R4 changes the way that session file names are evaluated. I don't see any reference to the change in the diffs, and if I step through the code using 0341494cda5fc9ca7bf011d491c54e8072969823 and 1dc012df6d9a77fc8ccc9355807793daf5fb1f0d (which look the same to me, just different commit ids b/c different unconnected repos), the push code works as expected. However If I use R4 without the repo version of the component, I get the failure. 19.1 and R3 work fine.

mesopelagique commented 2 years ago

Hi, I take this 19R4 branch code so from github and put it in our VCS in 19R4 branch and no diff at all

If there is different behaviour when replacing a component, it could a difference between compiled version or source/interpreted version and I test only in interpreted mode I will push a fix today I think and a new 19R4beta version will come tomorrow