Certificate auth improvements

[yannicktrinh]

Hello

Thank you for your contribution, I will discuss with the PO and study the code ASAP, however, to minimize the number of changes in the sources and make code review easier for me, would it be possible for you to use the code formatter available in Visual Studio Code by installing the 4D-Analyser module ?

All code modifications in 4D-NetKit should use English language without tokens (to save space and make it easier to read).

Thanks in advance

Reagards Yannick

[SBlaserBossinfo]

Hello

Thank you for your contribution, I will discuss with the PO and study the code ASAP, however, to minimize the number of changes in the sources and make code review easier for me, would it be possible for you to use the code formatter available in Visual Studio Code by installing the 4D-Analyser module ?

All code modifications in 4D-NetKit should use English language without tokens (to save space and make it easier to read).

Thanks in advance

Reagards Yannick

Hi Yannick

Great! Glad to hear that our suggestions from bossinfo has been received! I unchecked the token in the code as you can see in the last commit, is it now better readable? I can't do anything about the whitespace with the vsc extension. As you may know you can disable the whitespace in github. If there are any question don't hesitate to contact me.

Thank you

Regards Sebastian

[e-marchand]

recheck

[github-actions[bot]]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[SBlaserBossinfo]

I have read the CLA Document and I hereby sign the CLA

[e-marchand]

@SBlaserBossinfo

Hi there is some issue with our mecanism of CLA (that I try to fix), could you repost the message sorry for inconvenience I expect that we do not have to recreate the PullRequest (and branch)

thanks

[SBlaserBossinfo]

Hi @e-marchand no worries, what do you mean with repost the message?😅

[e-marchand]

Hi @e-marchand no worries, what do you mean with repost the message?😅

I have read the CLA Document and I hereby sign the CLA this one https://github.com/4d/4D-NetKit/pull/36#issuecomment-1801181011

just as new message

[SBlaserBossinfo]

I have read the CLA Document and I hereby sign the CLA

[SBlaserBossinfo]

@e-marchand Like that?

I have read the CLA Document and I hereby sign the CLA

[e-marchand]

Ok I see the issue, we do not accept "Merge" commit and that's why cla folder has been imported

@SBlaserBossinfo if you add me into your repository https://github.com/SBlaserBossinfo/4D-NetKit/settings/access with admin and right access, I will fix the branch, or maybe create a clean one my account is "e-marchand"

and then we will a new clean PullRequest

---

the other way maybe more clean is to create a new branch from main(main synchronized from this main, not your current main mirror), copy paste code code modification, then create a new PR

[SBlaserBossinfo]

Ok I see the issue, we do not accept "Merge" commit and that's why cla folder has been imported

@SBlaserBossinfo if you add me into your repository https://github.com/SBlaserBossinfo/4D-NetKit/settings/access with admin and right access, I will fix the branch, or maybe create a clean one my account is "e-marchand"

and then we will a new clean PullRequest

the other way maybe more clean is to create a new branch from main(main synchronized from this main, not your current main mirror), copy paste code code modification, then create a new PR

I'm on it 👍

[e-marchand]

thank you I close this one

37