search

4d / 4D-NetKit

4D NetKit is a built-in 4D component that allows you to interact with third-party web services and their APIs.
Other
13 stars 8 forks source link

Issue 63 token expiration not checked once it is issued #64

Closed macMikey closed 5 months ago

macMikey commented 5 months ago

https://github.com/4d/4D-NetKit/issues/63 Per this thread on the forum, the token expire is not being checked.

github-actions[bot] commented 5 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

macMikey commented 5 months ago

I have read the CLA Document and I hereby sign the CLA

macMikey commented 5 months ago

recheck

e-marchand commented 5 months ago

the commit is from "mustache-inc" account , so like other first PullRequest it must be signed by the commit author (you have already signed as macMikey)

PS: I am not the dev of this 4D Component (but have some knowledge about oauth because of my lib OAuthSwift for iOS), I do not think it's the solution to request token each time I will regenerate a token after receiving an exception about token expired

macMikey commented 5 months ago

@e-marchand i don't understand why github keeps misassigning the author to some other account. annoying. on the PR, itself, we are not requesting the token, each time. by removing the if block, we are just triggering the check to see if it expired, which then causes the refresh token to be used to get a new access token.

@yannicktrinh that's what you get if you remove the if. see the PR

macMikey commented 5 months ago

i'm going to close this PR, since the attribution is wrong, again, and try to resubmit it.