4d / 4D-NetKit

4D NetKit is a built-in 4D component that allows you to interact with third-party web services and their APIs.
Other
13 stars 8 forks source link

oauth2Provider properties listed as optional but are mandatory #68

Open macMikey opened 3 months ago

macMikey commented 3 months ago

here's the jwt document for google for web apps here's the jwt document for google for service accounts for web apps, the following fields are mandatory (but the netkit documentation says they're optional)

e-marchand commented 3 months ago

response_type seems to be set as "code" , because it cannot be changed for the moment, I think it must not be documented in this case (but maybe I do not read enought code) https://github.com/4d/4D-NetKit/blob/a77462e4704ec889fe8eee884e735fe8232b57db/Project/Sources/Classes/OAuth2Provider.4dm#L876

--

scope is not mandatory in Oauth2 protocol, it depend on api you use, it could even be ignored by server according to your right the server must choose a default one (as RFC say)

maybe doc could add mention when it is needed

macMikey commented 3 months ago

right. it's different, depending on the provider. rather than just changing the docs and issuing a PR, i wanted to throw out an issue, first, to discuss. what i would suggest is that: