4darsh-Dev / DecenTrade

DecenTrade is a decentralized digital marketplace built on the Ethereum blockchain, enabling secure and transparent transactions for digital assets.
https://decentrade.vercel.app
MIT License
14 stars 63 forks source link

[Bug]: Error handling at explore page #96

Closed IkkiOcean closed 3 weeks ago

IkkiOcean commented 4 weeks ago

Is there an existing issue for this?

What happened?

When navigating to the explore page, if the user's wallet is not found, the application continues to load indefinitely without showing an error message. There is no proper error handling in place, which leads to a poor user experience as users are left waiting without any feedback.

Current Behavior:

Expected Behavior:

Steps to Reproduce:

  1. Navigate to the explore page without a connected wallet or with an unsupported wallet.
  2. Observe the loading spinner continuing indefinitely without any error message.

Proposed Solution:

  1. Implement error handling for the "Wallet Not Found" case.
    • If the wallet is not detected, display a clear error message like: Wallet not found. Please connect a valid wallet to explore items.
  2. Stop the loading spinner when the error occurs to avoid infinite loading.
  3. Ensure proper fallback behavior so the user can try reconnecting or return to a previous state.

Add ScreenShots

Screenshot 2024-10-20 at 2 10 52 PM

What browsers are you seeing the problem on?

Safari

Record

IkkiOcean commented 4 weeks ago

Assign me under GSSOC-ext please

github-actions[bot] commented 4 weeks ago

You've successfully raised your issue, We'll get back to you soon. Don't forget to star⭐ the Repo.

4darsh-Dev commented 4 weeks ago

assigned to you @IkkiOcean, We've updated our project setup recent visit : https://decentrade.vercel.app/

Try creating a nft to check the feature

IkkiOcean commented 4 weeks ago

assigned to you @IkkiOcean, We've updated our project setup recent visit : https://decentrade.vercel.app/

Try creating a nft to check the feature

I tried creating nft but the create button didnt work..

IkkiOcean commented 4 weeks ago

@4darsh-Dev while working on explore page, I also notice that similar errors are also present on create NFT page so I will be handling them also. We need to implement a check for where the user has connected their wallet to not.

Screenshot 2024-10-20 at 10 45 57 PM

Do you like the error message or you want something else?

4darsh-Dev commented 3 weeks ago

@IkkiOcean you need to use metmask or any web3 wallet for adding nfts -- currently we're using Ethereum sepolia test net -- you can use this feature after adding faucets from chainlink

IkkiOcean commented 3 weeks ago

@4darsh-Dev okay. well I dont have much experience in web3 but I did added the error handling in the explore page so do look at it.

4darsh-Dev commented 3 weeks ago

Hey @IkkiOcean ! Thank you so much for your raising the issue💗 It’s all yours, you can come anytime again and make some contributions! 🚀 Alone, we can do little, but together we can do so much! 😇