Closed gdrosos closed 1 year ago
Hi @willronchetti, @alexander-veit,
I've further analyzed the history of the requests
dependency in the project and noticed that it was added on 138502e40edacf9d214a6529e25b6b9c979d9a53 and subsequently its usage was reduced over time, e.g., in c00c26ada54d894886df011a36dcfee76812b2b6. It now appears to be entirely unused. I thought this additional context might be helpful in reviewing the PR.
Looking forward to your feedback when you have a moment. Thank you for your time and consideration!
Please bump a patch version in pyproject.toml
and add a CHANGELOG
entry and I will allow a build and we will take this. Thanks for doing it!
You are welcome, @willronchetti.
I've bumped the version to 3.3.3 in pyproject.toml
and added the respective CHANGELOG
entry. Please let me know if there are any other changes needed.
Thank you for your feedback!
I also reverted the changes in poetry.lock
since I wasn't quite sure if I should be the one autogenerating it after the updates in pyproject.toml
You are fine to run poetry update
, I will double check the change.
Hello @willronchetti , I commited the updated version of poetry.lock
.
This passed our tests locally so I am merging, thanks for the contribution!
Summary
This pull request removes the unused dependency
requests
from thepyproject.toml
& poetry configuration files. This detection and removal is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.Rationale
Upon the analysis of the source code, we detected that the
requests
is no longer utilised in the source code while it still remains as a requirement in the project's dependencies files. Since it is no longer being directly utilized, removing this unused dependency will reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.Changes
Removed the
requests
dependency from thepyproject.toml
file.Removed the
requests
dependency from the Poetry configuration file.Impact
Reduced Package Size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.
Simplified Dependency Tree: Fewer dependencies make the project easier to maintain and can speed up installation.