ECR refactor and new class ECRTagWatcher

4dn-dcic / utils

various util modules shared amongst several projects in our organization

MIT License

4 stars 1 forks source link

This adds a new class ecr_utils.ECRTagWatcher that may be useful in Foursight to know if it's time to deploy.
This does some detailed refactoring of ecr_utils.py and ecr_scripts.py. See CHANGELOG.rst for details.
Added qa_utils support for ECR client.
Added unit tests for new functionality.
Added unit tests for some pre-existing ECRUtils functionality.

Opportunistic:

There were some syntax problems with the changelog that were not making things unreadable but were generating the wrong markup, so I did some adjustments.

Pull Request Test Coverage Report for Build 3010729776

130 of 183 (71.04%) changed or added relevant lines in 3 files are covered.

4 unchanged lines in 1 file lost coverage.

Overall coverage increased (+0.5%) to 71.238%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
dcicutils/qa_utils.py	63	76	82.89%
dcicutils/ecr_scripts.py	0	18	0.0%
dcicutils/ecr_utils.py	67	89	75.28%
<!--	Total:	130	183	71.04%	-->

Changes Missing Coverage

Covered Lines

Changed/Added Lines

82.89%

0.0%

75.28%

<!--

Total:

130

183

71.04%

-->

Files with Coverage Reduction	New Missed Lines	%
dcicutils/ecr_scripts.py	4	0%
<!--	Total:	4		-->

Files with Coverage Reduction

New Missed Lines

<!--

Total:

-->

Totals

Change from base Build 3001621837:

0.5%

Covered Lines:

5454

Relevant Lines:

7656

4dn-dcic / utils