4dn-dcic / utils

various util modules shared amongst several projects in our organization
MIT License
4 stars 1 forks source link

Refactored recording tech #223

Closed netsettler closed 1 year ago

netsettler commented 1 year ago

This refactors the test recording technology so that it would be easier to make more kinds (e.g., if we want something to use in cgap-portal). It may have to still change more later, but @willronchetti and I talked about it and agreed it's better just to freeze it its current form for now so it gets into master and doesn't stuffer bit rot, and worry about that later.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3192647038


Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/ff_mocks.py 139 157 88.54%
<!-- Total: 142 160 88.75% -->
Files with Coverage Reduction New Missed Lines %
dcicutils/ff_mocks.py 1 91.87%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 3161672036: 1.6%
Covered Lines: 5681
Relevant Lines: 7784

💛 - Coveralls
netsettler commented 1 year ago

I deployed this to devtest and poked at it a bit. It seems to be operating normally.

netsettler commented 1 year ago

I deployed this to devtest and poked at it a bit. It seems to be operating normally.

Oh, odd. Just noticed this comment, which was meant for a different PR. One doesn't deploy utils, so hopefully that didn't confuse @willronchetti.