4dn-dcic / utils

various util modules shared amongst several projects in our organization
MIT License
4 stars 1 forks source link

Python 3.11 upgrade #279

Closed dmichaels-harvard closed 11 months ago

dmichaels-harvard commented 1 year ago

Bump required PyYAML version to ^6.0.1 to resolve a Mac M1 issue with downstream builds.

As @netsettler notes in discussion on utils PR #277, the PyYAML Change Log says this about major version 6:

6.0 (2021-10-13)

* https://github.com/yaml/pyyaml/pull/327 -- Change README format to Markdown
* https://github.com/yaml/pyyaml/pull/483 -- Add a test for YAML 1.1 types
* https://github.com/yaml/pyyaml/pull/497 -- fix float resolver to ignore `.` and `._`
* https://github.com/yaml/pyyaml/pull/550 -- drop Python 2.7
* https://github.com/yaml/pyyaml/pull/553 -- Fix spelling of “hexadecimal”
* https://github.com/yaml/pyyaml/pull/556 -- fix representation of Enum subclasses
* https://github.com/yaml/pyyaml/pull/557 -- fix libyaml extension compiler warnings
* https://github.com/yaml/pyyaml/pull/560 -- fix ResourceWarning on leaked file descriptors
* https://github.com/yaml/pyyaml/pull/561 -- always require `Loader` arg to `yaml.load()`
* https://github.com/yaml/pyyaml/pull/564 -- remove remaining direct distutils usage

Based on this, he reasons:

It looks like really dropping Python 2 is the major incompatible change, though the "always require Loader arg to yaml.load()" might require some research to make sure we weren't breaking something.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6421775176


Files with Coverage Reduction New Missed Lines %
dcicutils/s3_utils.py 1 87.41%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 6354871296: -0.009%
Covered Lines: 8477
Relevant Lines: 10917

💛 - Coveralls