search

4doom4 / python-voipms

Python client for v1 of voip.ms REST API
MIT License
23 stars 11 forks source link

Fix didsorder API methods #7

Closed andrewlangemann closed 2 years ago

andrewlangemann commented 2 years ago

All the didsorder methods fail because they expect to call VoipMsClient._get() with a tuple instead of individual method and parameters params. This fixes them by making _get() smarter to allow this scenario.

andrewlangemann commented 2 years ago

@4doom4 @jjfalling If this all looks good, any chance we can publish a new version of the package to PyPi?

4doom4 commented 2 years ago

@andrewlangemann I currently have no time to maintain this repo. Would you be interested in helping out?

andrewlangemann commented 2 years ago

@andrewlangemann I currently have no time to maintain this repo. Would you be interested in helping out?

@4doom4 Yes I would be interested - what do I need to do?

4doom4 commented 2 years ago

I added you to the repo as collaborator.

andrewlangemann commented 2 years ago

@4doom4 Thank you - can you add me as an owner on the PyPI package? My PyPI username is "andrewlangemann"

4doom4 commented 2 years ago

@andrewlangemann done!