4doom4 / python-voipms

Python client for v1 of voip.ms REST API
MIT License
23 stars 11 forks source link

client.calls.get.cdr() #9

Open ddrg opened 2 years ago

ddrg commented 2 years ago

Can you return a null list rather than throwing a type error ("TypeError: There are no CDR entries for the filter") if there are no CDR entries.

ddrg commented 2 years ago

Can you return a null list for all functions returing a list (e.g., client.voicemail.get.voicemail_messages()) rather than throwing an error.

ddrg commented 2 years ago

Probably would be good to simply document that unless the caller catches exceptions, your functions will raise and error and quit.